Skip to content

Azure Split - Step 3 - Tie Everything Together#3908

Merged
paulmedynski merged 18 commits intomainfrom
dev/paul/azure/step3
Feb 10, 2026
Merged

Azure Split - Step 3 - Tie Everything Together#3908
paulmedynski merged 18 commits intomainfrom
dev/paul/azure/step3

Conversation

@paulmedynski
Copy link
Contributor

@paulmedynski paulmedynski commented Jan 22, 2026 •
edited
Loading

Description

This PR ties everything together:

  • Removes Azure authentication files from the MDS projects.
  • Adds dependencies to the Abstractions package everywhere necessary.
  • Updates pipelines to include Abstractions and Azure packages where necessary.
  • Removed some unnecessary flexibility in the MDS official pipeline.

PR series:

Testing

  • Normal PR/CI pipeline runs will validate most changes.
  • Manual inspection of pipeline logs and artifacts will confirm some of the fiddly parts.

@paulmedynski paulmedynski added this to the 7.0.0-preview4 milestone Jan 22, 2026
@paulmedynski paulmedynski added the Area\Azure Connectivity Use this to tag issues that are related to Azure connectivity. label Jan 22, 2026
Copilot AI review requested due to automatic review settings January 22, 2026 15:41
This was referenced Jan 22, 2026
Merged
Merged
@paulmedynski paulmedynski mentioned this pull request Jan 22, 2026
Closed
Copilot AI reviewed Jan 22, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request is the third step in the Azure Split work, which removes Azure authentication implementation from the main SqlClient project and establishes dependencies on the new Abstractions package. The PR removes Azure-specific authentication code, updates project dependencies, adds test authentication providers, and updates CI/CD pipelines to handle the new package structure.

Changes:

  • Removes ActiveDirectoryAuthenticationProvider, SqlAuthenticationProvider, SqlAuthenticationToken, SqlAuthenticationParameters, and related Azure authentication classes from the MDS source
  • Adds dependency on Microsoft.Data.SqlClient.Extensions.Abstractions package across all MDS projects (src and ref)
  • Updates test infrastructure with UsernamePasswordProvider and ManagedIdentityProvider implementations for manual tests
  • Updates all pipeline YAML files to include AbstractionsPackageVersion parameter and propagate it through build and test steps

Reviewed changes

Copilot reviewed 45 out of 45 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tools/specs/Microsoft.Data.SqlClient.nuspec Adds Abstractions package dependency to all target frameworks
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlAuthenticationProviderManager.cs Implements dynamic loading of Azure extension package as default provider
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Connection/SqlConnectionInternal.cs Refactors token acquisition retry logic to use new exception model
src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/*.cs Adds test authentication providers
src/Microsoft.Data.SqlClient/**/Microsoft.Data.SqlClient.csproj Removes Azure.* package references, adds Abstractions reference
eng/pipelines/**/*.yml Adds AbstractionsPackageVersion parameter throughout

Copilot AI review requested due to automatic review settings January 22, 2026 16:26
Copilot AI reviewed Jan 22, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 45 out of 45 changed files in this pull request and generated no new comments.

@codecov
Copy link

codecov bot commented Jan 23, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 52.63158% with 90 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.16%. Comparing base (104a401) to head (cc3917e).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...Data/SqlClient/SqlAuthenticationProviderManager.cs 44.66% 57 Missing ⚠️
...Data/SqlClient/Connection/SqlConnectionInternal.cs 51.61% 15 Missing ⚠️
...ta/SqlClient/SqlAuthenticationParametersBuilder.cs 77.55% 11 Missing ⚠️
...SqlClient/src/Microsoft/Data/Common/AdapterUtil.cs 0.00% 7 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (104a401) and HEAD (cc3917e). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (104a401) HEAD (cc3917e)
addons 1 0
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3908      +/-   ##
==========================================
- Coverage   74.91%   67.16%   -7.76%     
==========================================
  Files         269      260       -9     
  Lines       43279    65704   +22425     
==========================================
+ Hits        32422    44128   +11706     
- Misses      10857    21576   +10719
Flag Coverage Δ
addons ?
netcore 67.44% <48.42%> (-7.50%) ⬇️
netfx 66.13% <52.63%> (-8.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paulmedynski paulmedynski marked this pull request as ready for review January 26, 2026 15:41
@paulmedynski paulmedynski requested a review from a team as a code owner January 26, 2026 15:41
Copilot AI review requested due to automatic review settings January 26, 2026 15:41
@paulmedynski paulmedynski changed the title [Draft] Azure Split - Step 3 - Tie Everything Together Azure Split - Step 3 - Tie Everything Together Jan 26, 2026
Copilot AI reviewed Jan 26, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 51 out of 51 changed files in this pull request and generated 2 comments.

@paulmedynski paulmedynski mentioned this pull request Jan 27, 2026
Merged
@priyankatiwari08 priyankatiwari08 self-assigned this Feb 2, 2026
Base automatically changed from dev/paul/azure/step2 to main February 2, 2026 19:32
@paulmedynski
Task 41737: Merge feat/azure-split to main: Step 3 - Tie everything t…
1f11388 
…ogether

- Brought over all of the remaining code and project changes.
@paulmedynski
Task 41737: Merge feat/azure-split to main: Step 3 - Tie everything t…
bf0b91a 
…ogether

- Brought over the pipeline changes.
- Removed unnecessary flexibility from the MDS official pipeline tree.
@paulmedynski
Task 41737: Merge feat/azure-split to main: Step 3 - Tie everything t…
af49e59 
…ogether

- Removed Azure parameters from CI test tree.
@paulmedynski
Task 41737: Merge feat/azure-split to main: Step 3 - Tie everything t…
dbb1e15 
…ogether

- Fixed missing Abstractions and MDS package version parameters.
@paulmedynski
Task 41737: Merge feat/azure-split to main: Step 3 - Tie everything t…
313e26a 
…ogether

- Re-activate the Azure tests.
- Address PR comments.
@paulmedynski
Task 41737: Merge feat/azure-split to main: Step 3 - Tie everything t…
ad7ea2f 
…ogether

- Addressed a few final comments from the Step 2 PR.
Copilot AI review requested due to automatic review settings February 2, 2026 19:41
Copilot AI review requested due to automatic review settings February 4, 2026 14:36
Copilot AI reviewed Feb 4, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 63 out of 64 changed files in this pull request and generated 1 comment.

@paulmedynski
Task 41737: Merge feat/azure-split to main: Step 3 - Tie everything t…
5685229 
…ogether

- Addressed Copilot review comments.
mdaigle
mdaigle requested changes Feb 4, 2026
View reviewed changes
@paulmedynski
Task 41737: Merge feat/azure-split to main: Step 3 - Tie everything t…
df540b1 
…ogether

- Now using reference type to choose NuGet config file.
Copilot AI review requested due to automatic review settings February 4, 2026 18:18
Copilot AI reviewed Feb 4, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 63 out of 64 changed files in this pull request and generated 1 comment.

@paulmedynski
Task 41737: Merge feat/azure-split to main: Step 3 - Tie everything t…
ef0a194 
…ogether

- Fixed Azure build command lines.
@paulmedynski
Task 41737: Merge feat/azure-split to main: Step 3 - Tie everything t…
4f9c47b 
…ogether

- Added missing reference type to AKV restore targets.
Copilot AI review requested due to automatic review settings February 4, 2026 19:37
Copilot AI reviewed Feb 4, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 63 out of 64 changed files in this pull request and generated 1 comment.

mdaigle
mdaigle previously approved these changes Feb 5, 2026
View reviewed changes
mdaigle
mdaigle previously approved these changes Feb 5, 2026
View reviewed changes
Copilot AI review requested due to automatic review settings February 9, 2026 11:04
Copilot AI reviewed Feb 9, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 63 out of 64 changed files in this pull request and generated 6 comments.

@paulmedynski paulmedynski merged commit 356ef6c into main Feb 10, 2026
298 of 300 checks passed
@paulmedynski paulmedynski deleted the dev/paul/azure/step3 branch February 10, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@benrr101 benrr101 benrr101 approved these changes

@mdaigle mdaigle mdaigle approved these changes

@cheenamalhotra cheenamalhotra cheenamalhotra approved these changes

@samsharma2700 samsharma2700 samsharma2700 approved these changes

+1 more reviewer

@edwardneal edwardneal edwardneal left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@priyankatiwari08 priyankatiwari08

Labels

Area\Azure Connectivity Use this to tag issues that are related to Azure connectivity.

Projects

None yet

Milestone

7.0.0-preview4

Development

Successfully merging this pull request may close these issues.

7 participants

@paulmedynski @benrr101 @mdaigle @cheenamalhotra @edwardneal @samsharma2700 @priyankatiwari08